scorecard
scorecard copied to clipboard
:seedling: Fix pinsDependencies outcomes
What kind of change does this PR introduce?
probe cleanup
- [X] PR title follows the guidelines defined in our pull request documentation
What is the current behavior?
- OutcomeNotAvailable was used for cases where there are no dependencies.
- The description mentions this is for API issues which isn't the case here.
- OutcomeNotApplicable was used for cases where our data is inconsistent?
- Probe outcome descriptions are wrong
What is the new behavior (if this is a feature change)?**
- Inconsistent data states are now
OutcomeNotSupported, asOutcomeErroris already used for processing errors (#3515)- I'm not sure this is a perfect match, open to suggestions
- Situations with no supported dependencies now use
OutcomeNotApplicable - Probe documentation updated to fix copy/paste mistake
- Tests were added for processing errors and no dependencies
- Finding locations were simplified (see 6439b056c306bed2429acf5304fa21338f8dfd52 for details)
- [X] Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
Fixes #3855
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their application as a result of this pull request.)
NONE
Codecov Report
Merging #3961 (ea7c906) into main (2a45ba6) will decrease coverage by
6.40%. The diff coverage is100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## main #3961 +/- ##
==========================================
- Coverage 74.92% 68.53% -6.40%
==========================================
Files 223 223
Lines 16086 16046 -40
==========================================
- Hits 12053 10997 -1056
- Misses 3264 4348 +1084
+ Partials 769 701 -68
/scdiff generate Pinned-Dependencies