scorecard icon indicating copy to clipboard operation
scorecard copied to clipboard

:sparkles: Validation for command-line flags

Open naveensrinivasan opened this issue 3 years ago • 9 comments

What kind of change does this PR introduce?

feature

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Included validation for command line flags.
  • [x] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

https://github.com/ossf/scorecard/issues/1693

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to the release-note

(In particular, describe what changes users might need to make in their application as a result of this pull request.)


Included validation for command line flags.

naveensrinivasan avatar Mar 18 '22 15:03 naveensrinivasan

Codecov Report

Merging #1750 (dcfb280) into main (10d46d5) will increase coverage by 3.29%. The diff coverage is 88.09%.

@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
+ Coverage   56.72%   60.02%   +3.29%     
==========================================
  Files          65       65              
  Lines        6378     6416      +38     
==========================================
+ Hits         3618     3851     +233     
+ Misses       2519     2318     -201     
- Partials      241      247       +6     

codecov[bot] avatar Mar 18 '22 15:03 codecov[bot]

Integration tests success for [3a3cb537355c642ab57bfa8a9ca5152f6120ac50] (https://github.com/ossf/scorecard/actions/runs/2004983485)

github-actions[bot] avatar Mar 18 '22 15:03 github-actions[bot]

Integration tests success for [a3c6b3828ec017ca9b73bfc453483b59dd0e34df] (https://github.com/ossf/scorecard/actions/runs/2054408186)

github-actions[bot] avatar Mar 28 '22 19:03 github-actions[bot]

Integration tests success for [01facbacc7c1f045b5d4e69b1c7ffe5d85315bd4] (https://github.com/ossf/scorecard/actions/runs/2054446273)

github-actions[bot] avatar Mar 28 '22 19:03 github-actions[bot]

Integration tests success for [dcfb28029295ff8701c61a08ad8037a4210d7e76] (https://github.com/ossf/scorecard/actions/runs/2055022441)

github-actions[bot] avatar Mar 28 '22 21:03 github-actions[bot]

@naveensrinivasan in our last sync you mentioned this PR needs more work. Let us know when this is ready for review.

azeemshaikh38 avatar Mar 29 '22 15:03 azeemshaikh38

@naveensrinivasan in our last sync you mentioned this PR needs more work. Let us know when this is ready for review.

It is ready for review.

naveensrinivasan avatar Mar 29 '22 18:03 naveensrinivasan

Stale pull request message

github-actions[bot] avatar Apr 09 '22 02:04 github-actions[bot]

Not stale.

naveensrinivasan avatar Apr 09 '22 03:04 naveensrinivasan