package-feeds icon indicating copy to clipboard operation
package-feeds copied to clipboard

Failing to marshal a package should not result in hard failure during publishing

Open Qinusty opened this issue 4 years ago • 2 comments

Failing to marshal a single package currently blocks the publishing of all subsequent packages, this is undesirable.

https://github.com/ossf/package-feeds/blob/ce53f3ea/cmd/scheduled-feed/main.go#L45-L50 is the relevant code chunk.

Qinusty avatar May 04 '21 12:05 Qinusty

Seems sensible that this shouldn't lead to a complete loss of the subsequent package data. This might be somewhere to add another event, and simply continue.

tom--pollard avatar May 06 '21 13:05 tom--pollard

Now that #123 has merged I'll look to update publishPackages() to handle errors on a per package basis, using errPub to align with poll()

tom--pollard avatar Jun 11 '21 12:06 tom--pollard