quantum-mechanics icon indicating copy to clipboard operation
quantum-mechanics copied to clipboard

Pseudopotential notebook not show update after interacting with widget.

Open unkcpz opened this issue 1 year ago • 3 comments

Please see the screen recording below, the green area disappeared after I change the value by interacting with the widget.

Peek 2023-02-28 17-25

unkcpz avatar Feb 28 '23 16:02 unkcpz

One needs to click the button to recalculated the pseudopotential and the green area will be shown.

dou-du avatar Mar 03 '23 10:03 dou-du

Consider wheather to remove the button and set continue_udpate = false

dou-du avatar Mar 03 '23 10:03 dou-du

Thanks @dou-du, I am okay with the button. If you still gonna to use the button, two things I think can improve:

  1. the background color better to make the button more easily found.
  2. If there is a problem calculating the result, the exception is raised as a message right below the button, and the user knows why it is not correct. You can check what we did in AiiDAlab the StatusHTMLWidget https://github.com/aiidalab/aiidalab-widgets-base/blob/d48415af72fac842ebb0faf8a054a99dbb63ebcc/aiidalab_widgets_base/utils/init.py#L163-L172.

unkcpz avatar Mar 03 '23 10:03 unkcpz