pg_hint_plan icon indicating copy to clipboard operation
pg_hint_plan copied to clipboard

To support PostgreSQL v15

Open mikecaat opened this issue 2 years ago • 2 comments

Hi,

I'm working to support PostgreSQL v15. Please review the patch. There are only minor changes.

Summary of changes are

  • Update Makefile, README and SPECS
  • Update the version from 1.4 to 1.5
  • Update the copied functions in core.c
  • Update the expected results of tests
  • Remove dynamic translation for regression which isn't no longer supported by PostgreSQL's code
  • Update copyright (but is it better to separate patch for another branches?)

I tested with the REL_15_RC1 tag of PostgreSQL and all regression tests passed.

Regards,

mikecaat avatar Sep 29 '22 01:09 mikecaat

I tested with the REL_15_RC2 tag of PostgreSQL and all regression tests passed.

mikecaat avatar Oct 05 '22 07:10 mikecaat

I tested with the REL_15_0 tag of PostgreSQL and all regression tests passed.

mikecaat avatar Oct 12 '22 00:10 mikecaat

Thank you for the work and sorry for the long delay. I took a look on this and find it generally fine.

5e48896: Mmm. this should be a typo of debug_print but have been giving no effect for a long time. So I agree to remove it.

27b0e27 is applied as-is with merging the revert.

91bd78b: I saw one of the changes so applied only that.

09aae03: Looks fine except it contained unnecessary files. Applied.

09aae03 is overwritten by bc96ecd. I don't have a particular favor on this but, yeah, keep taking the same way for now. (I'm surprised by "cat $1 |" accidentally allows to feed input via pipe.., but, erm, leave it as is.)

0a1d562, 8fdd221, 8fdd221, 0e8744a: I don't see any of them to happen on PG15. Omitted.

48738dd: Thaks for the tedious work.

-Summary: Optimizer hint on PostgreSQL 12 -Summary: Optimizer hint on PostgreSQL 15

:p Older versions have the same flaw?

(I mistakenly pushed at this time..)

b884e48: COPYRIGHT.postgresql needs that fix. Applied only that part.

63202c0: This is simply the result of update_copied_funcs.pl. I redo'd that script then pushed.

horiguti avatar Dec 06 '22 05:12 horiguti