ort
ort copied to clipboard
Purl-related improvements
Please have a look at the individual commit messages for the details.
Codecov Report
Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
Project coverage is 67.45%. Comparing base (
7143c32) to head (f2dca01). Report is 15 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| model/src/main/kotlin/utils/PurlUtils.kt | 88.23% | 0 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #9304 +/- ##
============================================
- Coverage 67.49% 67.45% -0.04%
Complexity 1200 1200
============================================
Files 241 241
Lines 8493 8499 +6
Branches 899 904 +5
============================================
+ Hits 5732 5733 +1
- Misses 2399 2402 +3
- Partials 362 364 +2
| Flag | Coverage Δ | |
|---|---|---|
| funTest-docker | 60.54% <ø> (ø) |
|
| funTest-non-docker | 33.60% <0.00%> (-0.04%) |
:arrow_down: |
| test | 37.46% <88.88%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I haven't done the grepping myself: Have you checked whether any test assets using urls e.g. OrtResult, need to be re-aligned with these changes?
Have you checked whether any test assets using urls e.g.
OrtResult, need to be re-aligned with these changes?
Wouldn't we get test failures then? But actually I'm wasn't expecting this PR to break too many things, as mostly namespaces which contain slashes are affected, which we seem to have none (as we currently don't have purl-namespaces for Go and Swift). The real "breaking" PR will come as follow-up, to handle this differently to account for the fact the ORT IDs don't assign namespaces to Go and Swift, but purl does.
Wouldn't we get test failures then?
In expected output like files yet, in file which are used only as input probably no.
In expected output like files yet, in file which are used only as input probably no.
Hmm. I tried to find relevant purls with %-encoding by running
git grep -El "pkg:.*%" | grep -vE "(expected|web-app-template)"
which only lists
model/src/test/kotlin/IdentifierTest.kt
plugins/scanners/scanoss/src/test/assets/scanMulti/mappings/scanoss-multi-response.json
whose matches seem to be ok.