ort icon indicating copy to clipboard operation
ort copied to clipboard

Migrate the Opossum reporter from Jackson to kotlinx-serialization (KxS)

Open sschuberth opened this issue 1 year ago • 3 comments

Ideally, this would also refactor the code to use properly typed data classes.

This is part of the https://github.com/oss-review-toolkit/ort/issues/3904 effort.

sschuberth avatar Jul 03 '24 12:07 sschuberth

@maxhbr is this something you could help with? Is there maybe even a JSON schema for Opossum that we could generate Kotlin code from?

sschuberth avatar Jul 03 '24 12:07 sschuberth

Hey, I posted it in our group chat.

maxhbr avatar Jul 03 '24 13:07 maxhbr

Hey, I posted it in our group chat.

Were there any responses @maxhbr?

sschuberth avatar Jul 16 '24 12:07 sschuberth

Hey, I posted it in our group chat.

Were there any responses @maxhbr?

@maxhbr is the Opossum reporter still in use from your side? Otherwise we could consider removing it from ORT instead of investing the time to migrate it to KxS.

sschuberth avatar Nov 19 '24 11:11 sschuberth

Yeah, we are difinitely still using it.

leslielazzarino avatar Nov 20 '24 07:11 leslielazzarino

Yeah, we are difinitely still using it.

Thanks @leslielazzarino for the comment. Is there also willingness to help maintaining it from your side, and assist with the migration to KxS?

sschuberth avatar Nov 20 '24 07:11 sschuberth

Hi @sschuberth I am taking a look.

alexzurbonsen avatar Nov 20 '24 08:11 alexzurbonsen

Hi @sschuberth I am taking a look.

Thank you @alexzurbonsen 🙏🏻

Ideally, the conversion would not be done by simply migrating those untyped maps to KxS equivalents, but by introducing a proper data model class (like e.g. for AOSD) at the same time.

sschuberth avatar Nov 20 '24 08:11 sschuberth