ort
ort copied to clipboard
FossID: Limit fossid snippets
Please have a look at the individual commit messages for the details.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.74%. Comparing base (
76237c2
) to head (5c336a3
). Report is 35 commits behind head on main.
:exclamation: Current head 5c336a3 differs from pull request most recent head 08c9e38. Consider uploading reports for the commit 08c9e38 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #8616 +/- ##
============================================
- Coverage 67.97% 67.74% -0.23%
Complexity 1005 1005
============================================
Files 244 244
Lines 7844 7844
Branches 876 876
============================================
- Hits 5332 5314 -18
- Misses 2129 2147 +18
Partials 383 383
Flag | Coverage Δ | |
---|---|---|
funTest-docker | 66.04% <ø> (-0.45%) |
:arrow_down: |
funTest-non-docker | 34.79% <ø> (+0.17%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Any objections from anybody against merging this?
There's a unit test failure now. Please first have a look at this.
@sschuberth, are you fine with merging?
@sschuberth, are you fine with merging?
I haven't looked at the latest iterations code-wise, and I'm not deep enough into the topic to do so in reasonable time. So I don't feel comfortable to formally approve, but if you've approved and all tests pass (the Docker Build failure seems unrelated, GitHub apparently just had some problems today), I don't see a reason not to merge. Please go ahead as you see fit.