ort
ort copied to clipboard
Upgrading components for PHP analysis (Composer 2 / PHP 8)
Hi, This PR is motivated by https://github.com/oss-review-toolkit/ort/issues/4971 I have upgraded both Composer and PHP, as it seemed relevant to real-life contexts.
Cheers, Camille
Codecov Report
Merging #5497 (14c237b) into main (d9e662a) will increase coverage by
0.13%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #5497 +/- ##
============================================
+ Coverage 72.70% 72.84% +0.13%
- Complexity 2045 2096 +51
============================================
Files 267 268 +1
Lines 14117 14203 +86
Branches 2084 2130 +46
============================================
+ Hits 10264 10346 +82
- Misses 2772 2773 +1
- Partials 1081 1084 +3
Flag | Coverage Δ | |
---|---|---|
funTest-analyzer-docker | 73.25% <100.00%> (+1.80%) |
:arrow_up: |
funTest-non-analyzer | 47.21% <ø> (-0.06%) |
:arrow_down: |
test | 32.69% <0.00%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
analyzer/src/main/kotlin/managers/Composer.kt | 55.96% <100.00%> (-21.11%) |
:arrow_down: |
analyzer/src/main/kotlin/managers/Unmanaged.kt | 34.88% <0.00%> (-10.58%) |
:arrow_down: |
scanner/src/main/kotlin/scanners/fossid/FossId.kt | 73.19% <0.00%> (-0.43%) |
:arrow_down: |
cli/src/main/kotlin/commands/ScannerCommand.kt | 38.07% <0.00%> (-0.40%) |
:arrow_down: |
...el/src/main/kotlin/licenses/LicenseInfoResolver.kt | 91.55% <0.00%> (ø) |
|
...src/main/kotlin/config/ScanStorageConfiguration.kt | 100.00% <0.00%> (ø) |
|
...main/kotlin/commands/UploadResultToSw360Command.kt | 19.14% <0.00%> (ø) |
|
model/src/main/kotlin/config/PostgresConnection.kt | 100.00% <0.00%> (ø) |
|
...n/kotlin/scanners/scancode/ScanCodeResultParser.kt | 91.89% <0.00%> (+0.05%) |
:arrow_up: |
... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d9e662a...14c237b. Read the comment docs.
This should be removed when upgrading base image to 22.04 LTS
This comment makes me wonder whether there are any blockers to move to Ubuntu 22.04 LTS instead?
This comment makes me wonder whether there are any blockers to move to Ubuntu 22.04 LTS instead?
I propose to supersede this PR with #5651. Would that be fine with you, @camillem?
As #5651 is merged now which conflicts with this PR, I'll close this one.
This comment makes me wonder whether there are any blockers to move to Ubuntu 22.04 LTS instead?
I propose to supersede this PR with #5651. Would that be fine with you, @camillem?
Yes, of course. Thanks.