ort icon indicating copy to clipboard operation
ort copied to clipboard

chore(model): Remove `IVY_VERSION_RANGE_INDICATORS`

Open sschuberth opened this issue 6 months ago • 3 comments

These are by now only used for an early return from getVersionRange(). As checking for a valid range is done by the RangesListFactory, the only remaining case to check for is the empty string, which would otherwise create a ">= 0.0.0" range.

Note that as of 8142cdc the variable name was misleading anyway, as it does not only contain Ivy version range indicators.

sschuberth avatar Jun 05 '25 09:06 sschuberth

Should this paragraph be changed too: https://github.com/oss-review-toolkit/ort/blob/0fdf6590f72b7e5f8e5a84ee69f8d9415bf4e8ed/website/docs/configuration/package-configurations.md?plain=1#L17-L19

nnobelis avatar Jun 05 '25 09:06 nnobelis

Should this paragraph be changed too:

Done in a separate commit.

sschuberth avatar Jun 05 '25 10:06 sschuberth

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.72%. Comparing base (cd3bc07) to head (1527bed).

Files with missing lines Patch % Lines
...del/src/main/kotlin/config/PackageConfiguration.kt 0.00% 1 Missing :warning:
model/src/main/kotlin/utils/VersionUtils.kt 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10441      +/-   ##
============================================
- Coverage     56.74%   56.72%   -0.02%     
  Complexity     1640     1640              
============================================
  Files           337      337              
  Lines         12476    12475       -1     
  Branches       1177     1177              
============================================
- Hits           7079     7076       -3     
- Misses         4945     4947       +2     
  Partials        452      452              
Flag Coverage Δ
funTest-non-docker 33.00% <0.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 05 '25 10:06 codecov[bot]