ort icon indicating copy to clipboard operation
ort copied to clipboard

Make simple license mappings more strict

Open sschuberth opened this issue 6 months ago • 5 comments

Please have a look at the individual commit messages for the details.

sschuberth avatar May 15 '25 11:05 sschuberth

@oss-review-toolkit/core-devs I would really like to finally get rid of the ambiguous simple license mappings that we already identified quite some time ago. I have implemented two variants via a check: A lenient and a stricter one. Let's discuss whether we can at least get the lenient check in. To me it's important that the criteria for checking ambiguity are objective and reproducible by tests.

sschuberth avatar May 15 '25 11:05 sschuberth

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.75%. Comparing base (23a177b) to head (89ebd75). Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10334   +/-   ##
=========================================
  Coverage     56.75%   56.75%           
+ Complexity     1644     1642    -2     
=========================================
  Files           337      337           
  Lines         12480    12480           
  Branches       1177     1177           
=========================================
  Hits           7083     7083           
  Misses         4945     4945           
  Partials        452      452           
Flag Coverage Δ
funTest-docker 71.03% <ø> (ø)
funTest-non-docker 32.97% <ø> (-0.14%) :arrow_down:
test-ubuntu-24.04 41.04% <ø> (ø)
test-windows-2022 41.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 15 '25 11:05 codecov[bot]

Splitting out the first two commits to https://github.com/oss-review-toolkit/ort/pull/10336.

sschuberth avatar May 15 '25 12:05 sschuberth

Consider adding information about the breaking change to the commit message and how users can deal with it.

MarcelBochtler avatar Jun 12 '25 11:06 MarcelBochtler

Consider adding information about the breaking change to the commit message and how users can deal with it.

I've reworded the commit message.

Can we now please move forward with this @oss-review-toolkit/tsc?

sschuberth avatar Jun 18 '25 11:06 sschuberth