split-pro icon indicating copy to clipboard operation
split-pro copied to clipboard

implemented i18n

Open kruemelro opened this issue 1 year ago β€’ 8 comments

I've implemented i18n translation framework and also added English and German as language. I'm no developer, so please have a look over it

kruemelro avatar Aug 30 '24 12:08 kruemelro

@kruemelro this is so awesome, great work!

i don't have much time this week, i'll review and merge it next week for sure. Thanks again!

KMKoushik avatar Aug 31 '24 04:08 KMKoushik

Really cool feature ! It would be great if the translations were also available on the homepage.

If I have some time, I'll add a language selector to the menu.

Striffly avatar Sep 11 '24 00:09 Striffly

I'll add Polish/Russian/Ukrainian translations after merge

vovagorodok avatar Oct 12 '24 12:10 vovagorodok

this is will be added to 2.0. i'll keep this PR open

KMKoushik avatar Oct 16 '24 23:10 KMKoushik

Really cool feature ! It would be great if the translations were also available on the homepage.

If I have some time, I'll add a language selector to the menu.

I have implemented the language selector in my branch that is based on this PR.

https://github.com/alexanderwassbjer/split-pro/tree/feature/i18n-support

alexanderwassbjer avatar Oct 27 '24 16:10 alexanderwassbjer

Good PR! Some missing strings otherwise good!

@KMKoushik I can continue on this PR and add all the missing strings, fix language switcher, date-fns locale support etc. Do you want me to continue and make a PR? 😊

alexanderwassbjer avatar Oct 31 '24 20:10 alexanderwassbjer

Any news here? Switching language would be great!

klodeckl avatar Feb 13 '25 09:02 klodeckl

Hi guys! πŸ‘‹

I implemented translations using i18n, following the approach already present in the project, but I made some significant improvements to make the code more organized, maintainable, and accessible even to those unfamiliar with programming.

What I did: Clear separation of translation files: I separated translations into distinct files for each language (e.g., groups_details.json, groups_page.json, etc.). This makes it easier to add new languages or modify existing translations without digging through the code.

Dynamic language support: It’s now possible to pass the desired language as a parameter (e.g., it or en), and the system will automatically load the correct translations. Additionally, duplicating an existing language folder will automatically add a menu item to switch to the newly created language, all without touching the code.

Why these changes are useful: Maintainability: Adding new languages or modifying translations is now much simpler.

Clarity: Translations are organized intuitively, making it easier for non-developers to work with them.

Flexibility: Dynamic language support makes the system ready for future expansions.

Link to the Pull Request: πŸ”— Click here to view the Pull Request #208

Screenshot: image image

Feel free to review and let me know if there are any suggestions or changes to make! 😊

Thanks, Rosso Simone

@kruemelro @KMKoushik @Striffly @vovagorodok @alexanderwassbjer

Rosso2004 avatar Mar 22 '25 17:03 Rosso2004

@kruemelro Are you still interested in implementing i18n? I'm not that familiar with i18n, maybe you and @Rosso2004 could collaborate on a joint PR? :)

krokosik avatar May 28 '25 09:05 krokosik

I would concentrate the efforts on PR #208, but can reopen if needed. Currently my focus is elsewhere, but if someone picks up translations I would be happy to review it and merge it

krokosik avatar Jun 11 '25 22:06 krokosik