gobgp icon indicating copy to clipboard operation
gobgp copied to clipboard
verified publisher icon osrg

Fix accepted/rejected adj-in commands

Open myaut opened this issue 1 year ago • 2 comments

Original logic for accepted/rejected commands was removed in 2dbca9e29a6813f2df53261ffaa59b9439c13fdd when IN policies were deprecated.

Then 7e5eb10a8470826a14ec225cf6a7264785ea3603 added support for server-side filtering based on IMPORT polcies, but CLI support wasn't added. Repurposing accepted/rejected commands for this.

myaut avatar Jul 19 '24 13:07 myaut

https://github.com/osrg/gobgp/commit/7e5eb10a8470826a14ec225cf6a7264785ea3603 wasn't merged? What do you mean?

fujita avatar Jul 26 '24 02:07 fujita

7e5eb10a8470826a14ec225cf6a7264785ea3603 contains only server-side changes. This PR contains CLI support for it.

myaut avatar Jul 26 '24 07:07 myaut

@fujita gentle ping

bayrinat avatar Sep 13 '24 09:09 bayrinat

I don't understand the situation. The server-side code isn't merged. Why we need to merge this pull request to add CLI support for that?

fujita avatar Sep 13 '24 23:09 fujita

Ugh, sorry for the confusion. The correct commit is bec61c4f38344febda7495a35afa02061bb2880b I guess - the one that adds a simple EnableFiltered to the server.

This PR sets said flag in the accepted/rejected commands.

myaut avatar Sep 15 '24 10:09 myaut

Pushed, thanks!

fujita avatar Sep 26 '24 12:09 fujita