send-max: respect configuration

[maxime-peim]

• send first SendMax routes for a given prefix to neighbors
• when route withdrawal, send the next filtered route
• add a local identifier to a path (rf:prefix:local id)
• register which paths are filtered per peer

[maxime-peim]

Hi @fujita I was not able to run zapi test locally, will it be possible to run the CI please?

[fujita]

I've just run the CI. btw, you can run the CI by forking the gobgp repository and creating a pull request for your repository.

[maxime-peim]

Thanks! This is what I have done, but the CI does not seem to be triggered when force-pushing

[maxime-peim]

Sorry, it should be good now. However, I didn't find a way to re-run the CI from my side apart from closing and reopening the PR...

[maxime-peim]

Hi @fujita @bayrinat, Do you have comments to do on that PR, please?

[maxime-peim]

Anyone?

[fujita]

Thanks a lot for working the feature! So each peer needs to keep filtered paths in memory. looks like it could consume lots of memory in some configurations. Any other way to implement that feature?

[maxime-peim]

Thanks a lot for working the feature! So each peer needs to keep filtered paths in memory. looks like it could consume lots of memory in some configurations. Any other way to implement that feature?

Hi @fujita, Each peer keeps a key to the path that is stored in the local RIB, it does not have a copy of the path. Maybe we could only store N filtered paths if the limit is set to N. So, we could replace all the advertised paths are withdrawn at once.

[fujita]

Thanks a lot!