gobgp
gobgp copied to clipboard
osrg
Are separate types for IPv4 and IPv6 prefixes necessary?
Hello,
I was just going to fix some slice capacity issue and I started digging around ... and to be honest, I'm lost around the IPAddrPrefix, IPAddrPrefixDefault and IPv6AddrPrefix. It all seems kinda messy and unnecessary. Am I missing something? I think there should be only one "IPAddrPrefix" which handles both IPv4 and IPv6 ... if there isn't any reason for the distinction that I'm missing, I can take a look into merging these into one struct.
Yeah, I made several mistakes on these prefix stuff. But I guess that there are good number of users who use them. I don't think that it's a good idea to change them largely just because we can have the better design. It's too late.
Ultimately it's your decision of course, but I would like to point out that its expected to change/break things with the new major version, so I personally wouldn't be afraid to change things for the better with the new major version. It to me certainly feels like a better option than to just carry your "mistakes" along forever.
What do you think about creating an issue/wiki page that tracks some possible breaking changes for future major releases?
сб, 25 дек. 2021 г., 16:25 Jakub Chábek @.***>:
Ultimately it's your decision of course, but I would like to point out that its expected to change/break things with the new major version, so I personally wouldn't be afraid to change things for the better with the new major version. It to me certainly feels like a better option than to just carry your "mistakes" alone forever.
— Reply to this email directly, view it on GitHub https://github.com/osrg/gobgp/issues/2512#issuecomment-1001017731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPURHT7RZBNGB3D34EZX33USXA4FANCNFSM5KLZRZQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
