osqp icon indicating copy to clipboard operation
osqp copied to clipboard

Make CMake compatible with nix

Open notalltim opened this issue 2 years ago • 6 comments

  • Add a EXTERNAL_QDLDL and QDLDL_ROOT to allow fetch content to work
  • remove $<INSTALL_PREFIX> from $<INSTALL_INTERFACE:...> This is a continuation of #481

notalltim avatar Jul 23 '23 23:07 notalltim

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 23 '23 23:07 CLAassistant

remove $<INSTALL_PREFIX> from $<INSTALL_INTERFACE:...>

This is already going to be merged as part of https://github.com/osqp/osqp/pull/559, since no one replied to my last question on that PR I just implemented what resources online were saying was the best way.

imciner2 avatar Jul 24 '23 09:07 imciner2

Awesome I missed that does making the external project using the internet optional make sense? I can rebase if it makes things easier

notalltim avatar Jul 24 '23 22:07 notalltim

does making the external project using the internet optional make sense

We had originally planned for a separate QDLDL to be usable, but that accidentally got missed during the major CMake rework. So we'd gladly accept any changes to make that possible.

imciner2 avatar Jul 25 '23 11:07 imciner2

@imciner2 Is this what you were looking for or did you have something else in mind?

notalltim avatar Oct 31 '23 01:10 notalltim

@imciner2 Still interested in getting this merged. Do you have any more requests?

notalltim avatar Feb 19 '24 03:02 notalltim

I apparently can't retarget this to the master branch after deleteing the old branch. Sorry about that, I thought I could do that after merging that.

imciner2 avatar Apr 04 '24 19:04 imciner2