osqp icon indicating copy to clipboard operation
osqp copied to clipboard

CI: Run all tests compiled for a configuration

Open imciner2 opened this issue 3 years ago • 1 comments

Instead of individually calling the tester, just use the ctest wrapper to call all the tests. Before this change we were skipping the linear algebra tests because they are now a separate tester executable, so with this change we restore the linear algebra tests.

imciner2 avatar Sep 23 '22 17:09 imciner2

Pull Request Test Coverage Report for Build 3114637586

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 80.888%

Totals Coverage Status
Change from base Build 3114276519: 2.6%
Covered Lines: 2916
Relevant Lines: 3605

💛 - Coveralls

coveralls avatar Sep 23 '22 17:09 coveralls

Looks great! Thanks @imciner2. Looks like in our case we need to do a plain make before a make test will succeed (as we're doing here in the CI). Just pointing it out in case you think this is something that needs "fixing".

vineetbansal avatar Sep 26 '22 20:09 vineetbansal

Looks like in our case we need to do a plain make before a make test will succeed (as we're doing here in the CI). Just pointing it out in case you think this is something that needs "fixing".

I think that's probably fine. We could try to update the CMake to automatically add the dependency there, but it is lower on the priority list.

imciner2 avatar Sep 26 '22 22:09 imciner2