sol icon indicating copy to clipboard operation
sol copied to clipboard

Usage of GitHub releases

Open SMillerDev opened this issue 1 year ago • 4 comments

I'm a maintainer for Homebrew, and when working on some style issues in casks I found that this software embeds releases in the repo, which is highly unusual and probably pretty bad for git performance. Would you consider adding the releases to the GitHub releases and tags so they are easier to find for people?

SMillerDev avatar Jun 21 '24 09:06 SMillerDev

hey, I think the releases folder was necessary for sparkle, can't remember. The homebrew listing was contributed in a PR so I don't really know how it works.

Moving to releases would be better indeed, but I'm going on vacation next week for 3 months, so I doubt I will get to it.

If you provide me with some docs I can try to take a look when I'm back.

ospfranco avatar Jun 21 '24 10:06 ospfranco

Don't worry about the Homebrew part. Nothing is wrong there. Enjoy your holiday, here's an apidoc about release assets for when you return: https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28

SMillerDev avatar Jun 21 '24 11:06 SMillerDev

The problem is sparkle and the generation of the binaries. I have everything setup on my machine, because it is easy with notarization. Having to setup everything on github actions or even on my machine will be time consuming. Given that this is a hobby project of mine and I make 0 moneys out of it... this will be not my prio... even for this year I guess :)

ospfranco avatar Jun 21 '24 11:06 ospfranco

I've recently migrated to using github releases with sparkle as well, this should be working now, though I'm not 100% sure I did not break anything.

ospfranco avatar Oct 04 '24 10:10 ospfranco

This seems to be working for now, at least on brew the latest version is being correctly fetched. Will close this. In case there are any issues just re-open it.

ospfranco avatar Nov 14 '24 09:11 ospfranco