anki-addons icon indicating copy to clipboard operation
anki-addons copied to clipboard

OALD url

Open Jimmy-Z opened this issue 9 years ago • 6 comments

'http://www.oxfordlearnersdictionaries.com/search/english/?q='

would be better than:

'http://www.oxfordlearnersdictionaries.com/definition/english/'

for example: 'Japan' via 1st URL vs 'Japan' via 2nd URL

Jimmy-Z avatar Jul 08 '15 13:07 Jimmy-Z

and OAAD, I know you've said you'll probably not add any more English downloaders.

like Heimlich maneuver,

oaad.py:

# download pronunciations from Oxford Advanced Learner's Dictionary

from .oald import OaldDownloader

class OaadDownloader(OaldDownloader):
    def __init__(self):
        OaldDownloader.__init__(self)
        self.url = \
                'http://www.oxfordlearnersdictionaries.com/search/american_english/?q='
        self.extras['Source'] = u'Oxford Advanced American Dictionary'

Jimmy-Z avatar Jul 08 '15 14:07 Jimmy-Z

you mentioned OAAD in this part of the manual, but actually only OALD is included.

Jimmy-Z avatar Jul 08 '15 14:07 Jimmy-Z

Well, OAAD, OALD, who can keep them apart. I’ll think about this. Btw, you get Heimlich maneuver from MW and Japan from lots of sites.

ospalh avatar Jul 08 '15 14:07 ospalh

I know, I know...

Jimmy-Z avatar Jul 08 '15 15:07 Jimmy-Z

And the chances i’ll publish the changes are better when you make a pull request. (But i guess i will not have OAAD and OALD activated by default, similar to American,British} Macmillan) And please

  • put an encoding and license header in the new file. Copy-and-paste, add your own ©
  • Make sure it is (mostly) PEP8-conform. GIYF
  • And add a (short) docstring to the class.

ospalh avatar Jul 08 '15 15:07 ospalh

Btw, i am not doing anything for this. If you want this in the main version, please make a pull request.

ospalh avatar Jul 31 '15 07:07 ospalh