Spring-Boot-Blog-REST-API icon indicating copy to clipboard operation
Spring-Boot-Blog-REST-API copied to clipboard

Request for Test Addition

Open alidehkhodaei opened this issue 1 year ago • 5 comments

Hello and thank you for this project!

I believe it would be great to have tests written for this project. Is it possible to add tests?

Having tests can greatly improve the overall quality and stability of the project. It allows for easier maintenance, prevents regression bugs, and helps ensure that the project behaves as expected in different scenarios.

alidehkhodaei avatar Jun 05 '23 20:06 alidehkhodaei

Welcome @alidehkhodaei to Spring-Boot-Blog-REST-API community! Thanks so much for creating your first issue :)

github-actions[bot] avatar Jun 05 '23 20:06 github-actions[bot]

Hi @alidehkhodaei, I started working on this project when I was learning and did not write tests :smile: For now I did not touch it long time.

Feel free to add tests if you would like.

osopromadze avatar Jun 06 '23 15:06 osopromadze

Hi, I was going backwards through codetriage.com to find a repo I could start contributing to. I saw this one and thought I would take a look.

I currently work as a Java and Spring developer. This issue seems like something I could pick up. I know a few things about writing good unit tests with JUnit.

Is this repo still actively maintained? If so, I wouldn't mind picking this up.

zachary-berdell-elliott avatar Nov 30 '23 05:11 zachary-berdell-elliott

I was going to ask what the rules are for contributing and forked this repo. I guess when I create a PR, it is raised to this repo. I wrote tests for AlbumServiceImpl and will continue to write tests for more classes even if this repository is no longer maintained just for fun. https://github.com/osopromadze/Spring-Boot-Blog-REST-API/compare/main...zachary-berdell-elliott:Spring-Boot-Blog-REST-API-tests-added:feature/add-junit-tests?expand=1

zachary-berdell-elliott avatar Dec 03 '23 19:12 zachary-berdell-elliott

I have added unit tests for most logical code. There may still be a few cases that need to be covered though. I also fixed a bug that I found with the deleteUser method in UserServiceImpl. If this repository is still maintained or if someone stumbles across this repository and wants to work on it, feel free to merge these changes.

zachary-berdell-elliott avatar Dec 23 '23 22:12 zachary-berdell-elliott