oso icon indicating copy to clipboard operation
oso copied to clipboard

`isaCheck` not working since 0.26.0

Open gkaemmer opened this issue 2 years ago • 2 comments

0.26.0 introduced "in-VM IsA checks" which improve performance in medium-to-large policies. The VM's IsA check relies on a classId passed from the host, which is obtained by looking at the given instance's class. In Node.js, this means that the isaCheck override is now ignored, and there's no way to otherwise control how Oso performs the instance -> classId mapping.

In the Node.js client, we should use isaCheck during the calculation of classId for a new instance.

gkaemmer avatar Mar 22 '22 18:03 gkaemmer

I also can confirm that isaCheck doesn't work as expected in 0.26.0 (node.js). If I rollback to the version 0.25.1 my code works correctly.

enheit avatar Apr 07 '22 07:04 enheit

Just wanted to bump this issue as It is still not fixed in 0.26.2. My builds started failing post dependency upgrade from 0.25.1.

Have reverted the version back to 0.25.1 for now.

shripadk avatar Aug 08 '22 14:08 shripadk

Fixed in #1615. Let me know if you're still facing trouble and I'll update.

samscott89 avatar Dec 21 '22 16:12 samscott89