osmosis
osmosis copied to clipboard
Gamm proto migration
Background
https://github.com/osmosis-labs/osmosis/blob/main/proto/osmosis/gamm/v1beta1/balancerPool.proto#L2-L5
We had a todo on gamm proto migration, and needed extra investigation on whether we needed extra migration.
I have attempted to change the proto package with the following changes https://github.com/osmosis-labs/osmosis/commit/4dbdce084718a4108bf9523ac596b755193ef890 and ran an upgrade on in place testnet, getting the following error
Error: rpc error: code = Unknown desc = rpc error: code = Internal desc = no concrete type registered for type URL /osmosis.gamm.v1beta1.Pool against interface *types.CFMMPoolI: unknown request
We would need further investigation on how we should be conducting a migration on the proto package.
Suggested Design
Here, you can put concrete steps as to what to do next e.g.
- create test file in...
Acceptance Criteria
Goals & criteria for success e.g.
- all existing and new tests should pass