osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

fix: add cosmos.msg.v1.service to message services

Open faddat opened this issue 1 year ago • 8 comments

What is the purpose of the change

This pull request resolves an issue I encountered with using Osmosis modules in a third party chain:

    service osmosis.poolmanager.v1beta1.Msg does not have cosmos.msg.v1.service proto annotation
    service osmosis.tokenfactory.v1beta1.Msg does not have cosmos.msg.v1.service proto annotation
    service osmosis.poolmanager.v1beta1.Msg does not have cosmos.msg.v1.service proto annotation
    service osmosis.tokenfactory.v1beta1.Msg does not have cosmos.msg.v1.service proto annotation

I think that the difference between osmosis and the other chain is the use of appv2, so I checked IBC and cosmwasm, and found the annotation there.

Testing and Verifying

This change is already covered by existing tests. If tests don't pass, or the change doesn't make sense to maintainers, please close this PR :)

Documentation and Release Note

  • [ ] Does this pull request introduce a new feature or user-facing behavior changes? no
  • [x] Changelog entry added to Unreleased section of CHANGELOG.md? shortly, yes

Where is the change documented?

  • [ ] Specification (x/{module}/README.md)
  • [ ] Osmosis documentation site
  • [ ] Code comments?
  • [ ] N/A

faddat avatar Sep 10 '24 12:09 faddat