osmosis chore: set optimistic execution

Closes: #XXX

What is the purpose of the change

As requested by @ValarDragon

Jun 15 '24 23:06 czarcas7ic

Walkthrough

The update enhances the osmosis platform by updating the CHANGELOG.md for version v27.0.0, detailing new features and fixes, including optimistic execution and various dependency version bumps. Additionally, a new command UpdateAssetListCmd is introduced in the CLI, improving asset management by allowing users to fetch and update asset lists. The underlying logic for loading asset lists has been refined to prioritize local files and improve error handling.

Changes

File/Path	Change Summary
`CHANGELOG.md`	Updated with new entries for "Unreleased" and "v27.0.0", including features, fixes, and chore entries for version bumps.
`cmd/osmosisd/cmd/root.go`	Added `UpdateAssetListCmd` for fetching and updating asset lists; enhanced `loadAssetList` for better error handling and mappings.

Possibly related PRs

#8831: Chore to bump the cometbft version, directly related to the main PR.
#8751: Fixes for supply offsets for the osmo token, mentioned in the changelog updates.
#8779: Chore to bump cometbft/cosmos-sdk versions, aligning with the main PR's updates.
#8807: Involves a bump of the cometbft version, connecting it to the changes made in the main PR.
#8822: Updates the changelog for the v27.0.0 release, relevant as the main PR also updates the changelog for the same version.
#8743: Focuses on updating the SDK and CometBFT versions, relevant to the versioning changes documented in the main PR.

Suggested labels

V:state/compatible/backport, A:backport/v26.x

Suggested reviewers

ValarDragon
czarcas7ic

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 671013fddb419f83abfe6cc2c20f1f3b9706169b and 04d41a032dd894bb38b5feffb14c50424e082368.

📒 Files selected for processing (2)

CHANGELOG.md (2 hunks)
cmd/osmosisd/cmd/root.go (1 hunks)

🔇 Additional comments (3)

cmd/osmosisd/cmd/root.go (1)

1045-1045: Enable Optimistic Execution in the base application

The addition of baseapp.SetOptimisticExecution() correctly enables the Optimistic Execution feature in the application, as requested.

CHANGELOG.md (2)

Line range hint 1-45: Changelog format follows best practices

The changelog properly follows the Keep a Changelog format with:

Clear categorization of changes
Semantic versioning
Reverse chronological ordering
PR references
Detailed descriptions

46-47: LGTM - State compatible changes properly documented

The changelog entries correctly document:

The addition of optimistic execution feature (#8393)
The cometbft bump (#8831)

Both changes are appropriately categorized under "State Compatible" since they don't introduce state-breaking changes.

Let's verify the state compatibility claim:

✅ Verification successful

Based on the search results, I can now provide a final response:

Enabling optimistic execution is a state-compatible change

The change to enable optimistic execution (#8393) is correctly categorized under the "State Compatible" section in the changelog, not under "State Breaking". This is supported by:

The change appears in the unreleased section under "State Compatible"
No state-breaking changes or consensus parameter modifications are associated with this PR
The feature appears to be a performance optimization that doesn't affect state persistence or consensus rules

The changelog categorization is accurate and no further verification is needed.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the changes don't modify any state-related code

# Check for any state store modifications in the PR
rg -A 5 "KVStore|MemStore|store.Set|store.Delete" 

# Check for any proto changes that could affect state
rg -A 5 "^message\s|^enum\s" "*.proto"

Length of output: 113752

Script:

#!/bin/bash
# Check for any state-breaking changes in the PR
# Look for changes in proto files that could affect state
fd -e proto -x cat {} \; 

# Look for any state-breaking changes in the changelog
rg -A 5 "State Breaking" CHANGELOG.md

# Look for any optimistic execution related changes
rg -A 5 "optimistic.*execution"

Length of output: 112584

Script:

#!/bin/bash
# Look for optimistic execution related changes in the codebase
rg -A 5 "optimistic.*execution" .

# Look for any state-breaking changes in the PR
rg -A 5 "State Breaking" .

# Check for any changes in consensus parameters or state-related code
rg -A 5 "consensus|state" CHANGELOG.md

Length of output: 16187

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Jun 16 '24 02:06 coderabbitai[bot]

Actually since this is state compat, maybe we should get v26.0.0 without this, and v26.1.0 with it?

Jun 19 '24 16:06 ValarDragon

@ValarDragon I was told by Facu from Binary Builders that the feat does nothing without 2/3 voting power on it.

We can add in minor but I don't think there is a high likelyhood of getting voting power on it without a manual push

(msg here https://osmosis-network.slack.com/archives/C047X1T6ERK/p1718615619678329?thread_ts=1718492283.495959&cid=C047X1T6ERK)

Jun 19 '24 19:06 czarcas7ic

Lets keep this open until v26.0.0 is out and then merge, as per Dev's request.

Jun 25 '24 21:06 czarcas7ic