fix: enforce sub authenticators to be greater than 1

[PaddyMc]

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documentation of area A by adding ....

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added unit test that validates ...
• Added integration tests for end-to-end deployment with ...
• Extended integration test for ...
• Manually verified the change by ...

Documentation and Release Note

• [ ] Does this pull request introduce a new feature or user-facing behavior changes?
• [ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

• [ ] Specification (x/{module}/README.md)
• [ ] Osmosis documentation site
• [ ] Code comments?
• [ ] N/A

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

[coderabbitai[bot]]

Walkthrough

This update strengthens the initialization logic for the AllOf and AnyOf sub-authenticator collections within the Osmosis project to ensure they contain a minimum of two sub-authenticators. Changes across various files enforce this rule during initialization and relevant test cases, ensuring initialization fails if these conditions are not met. Additionally, logic for testing these scenarios has been adjusted to handle these new rules correctly.

Changes

File Path	Change Summary
x/.../authenticator/all_of.go	Updated the Initialize method to require at least 2 sub-authenticators, modifying error handling accordingly.
x/.../authenticator/any_of.go	Added a check in Initialize to ensure a minimum of 2 sub-authenticators, with related error messages.
x/.../authenticator/composite.go	Changed onSubAuthenticatorsAdded to require at least 2 sub-authenticators for validation.
x/.../authenticator/composition_test.go	Updated TestAnyOf and TestAllOf test functions to include a new expectInit flag for error handling.
CHANGELOG.md	Documented the change enforcing more than 1 sub-authenticator in the pull request #8375.

Sequence Diagrams

The sequence diagrams for these changes are omitted as they involve straightforward adjustments to initialization checks and associated error handling.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.