osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

perf!: Don't try doing superfluid distributions to jailed validators

Open ValarDragon opened this issue 1 year ago • 2 comments

Closes: #XXX

What is the purpose of the change

Speedup superfluid distribution by not doing staking operations on jailed validators. Estimated impact is 10s reduction of epoch time.

TODO: Need to immediately remove all SF staking after jailing, and test that upon unjailing its correctly re-included. Ideally we do this by making these account intermediary connections be stored separately in state.

Testing and Verifying

TODO: Test this. This will likely block this PR from getting through to completion

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • [ ] Does this pull request introduce a new feature or user-facing behavior changes?
  • [ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • [ ] Specification (x/{module}/README.md)
  • [ ] Osmosis documentation site
  • [ ] Code comments?
  • [ ] N/A

ValarDragon avatar Apr 17 '24 06:04 ValarDragon

Question, couldn't we make a state compat version of this that skips jailed validators, and then in v25 the only diff would be we delete the intermediary accounts as well?

Also second question, intermediary accounts should be empty for all jailed validators right? Maybe we add a safety check for this so we don't discard pending rewards by accident?

czarcas7ic avatar Apr 22 '24 17:04 czarcas7ic

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

github-actions[bot] avatar May 01 '24 00:05 github-actions[bot]

Going to close this, as I don't see myself making tests for this any time soon

ValarDragon avatar May 13 '24 18:05 ValarDragon