osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

[Full Powered Token Factory] Fix Module constraints

Open mattverse opened this issue 3 years ago • 0 comments

Closes: #2572, #2753

What is the purpose of the change

This PR addresses some of the module level impacts by the Bank hooks, namely TrackBeforeSend hook and the BlockBeforeSend hook.

The PR addresses two module level impact in specific, where the before send hook can have impact,

  • lockup module
    • Remove panic from WithdrawAllMaturedLocks, instead have it continue when error
  • Incentives Module
    • logic to handle err from doDistributionSends. Would fail when failed to distribute right now, but the possibility that ceratin address could be blocked to receive, we need a distinct logic to handle this so that this does not panic (
  • Tokenfactory Module
    • added logic to prevent creating with subdenom of "superbonding" or "superunbonding"

Brief Changelog

  • Add logic for handling token factory denoms and bank hooks within the lockup module and the incentives module

mattverse avatar Oct 05 '22 07:10 mattverse