osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

Fix: Last error time now updates during record interpolation

Open migueldingli1997 opened this issue 3 years ago • 3 comments
trafficstars

Closes: #2909

What is the purpose of the change

This pull request resolves the issue that interpolated records that have an error were no longer considered erroneous after interpolation. In other words, if the last error time matches the record's time, these will also match in the interpolated record.

Brief Changelog

  • Last error time is updated during record interpolation if record has an error

Testing and Verifying

This change added tests and can be verified as follows:

  • Added unit test that ensures the last error time is updated if the record's time matches the last error time

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not documented

migueldingli1997 avatar Oct 01 '22 09:10 migueldingli1997

This looks good to me!

Can you add the test case you had in the github issue, which ensures the needed property at the api level?

ValarDragon avatar Oct 01 '22 15:10 ValarDragon

This looks good to me!

Can you add the test case you had in the github issue, which ensures the needed property at the api level?

Sure thing

migueldingli1997 avatar Oct 03 '22 06:10 migueldingli1997

I have not had the time to continue working on this, however please note that that after I added some additional rough test cases, there seems to be an issue at the API level as a result of my changes.

migueldingli1997 avatar Oct 12 '22 13:10 migueldingli1997

Updated @ValarDragon :) Please review the PR in its entirety as I did not just add a test; I modified the fix as well.

migueldingli1997 avatar Oct 14 '22 08:10 migueldingli1997