osmosis
osmosis copied to clipboard
Fix: Last error time now updates during record interpolation
Closes: #2909
What is the purpose of the change
This pull request resolves the issue that interpolated records that have an error were no longer considered erroneous after interpolation. In other words, if the last error time matches the record's time, these will also match in the interpolated record.
Brief Changelog
- Last error time is updated during record interpolation if record has an error
Testing and Verifying
This change added tests and can be verified as follows:
- Added unit test that ensures the last error time is updated if the record's time matches the last error time
Documentation and Release Note
- Does this pull request introduce a new feature or user-facing behavior changes? no
- Is a relevant changelog entry added to the
Unreleasedsection inCHANGELOG.md? yes - How is the feature or change documented? not documented
This looks good to me!
Can you add the test case you had in the github issue, which ensures the needed property at the api level?
This looks good to me!
Can you add the test case you had in the github issue, which ensures the needed property at the api level?
Sure thing
I have not had the time to continue working on this, however please note that that after I added some additional rough test cases, there seems to be an issue at the API level as a result of my changes.
Updated @ValarDragon :) Please review the PR in its entirety as I did not just add a test; I modified the fix as well.