osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

[Full-powered Tokenfactory] Apply `TrackBeforeSend`, `BlockBeforeSend`

Open mattverse opened this issue 2 years ago • 0 comments

Closes: #2567, #2570, #2629

What is the purpose of the change

(Note that is PR'd against fullpowere-tokenfactory branch, not the main branch.

cref: https://github.com/osmosis-labs/cosmos-sdk/pull/334 Having separated out BeforeSend hook into two subsequent hooks TrackBeforSend, BlockBeforeSend, full powered token factory also has to implement the new hooks that has been changed. Both methods / hooks call the before send listener, the difference being BlockBeforeSend catches error returning from the listener, while TrackBeforeSend does not catch or return errors that are returned from the contract

Minor changes included in this PR

  • Changed go.mod so that the cosmos-sdk dependecy points to the commit in https://github.com/osmosis-labs/cosmos-sdk/pull/334 (this is what also caused all the changes in proto files)
  • Changed SetBeforeSendHook msg to SetBeforeSendListener. Changed method names from setBeforeSendHook to `SetBefo
  • Changed so that PerformBurn does not check for burn address

mattverse avatar Sep 29 '22 09:09 mattverse