osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

feat: streamswap implementation

Open robert-zaremba opened this issue 2 years ago • 7 comments

Implementation for x/streamswap (moving from the old osmolbp branch).

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

robert-zaremba avatar Sep 04 '22 11:09 robert-zaremba

Spec will be added later today or tomorrow.

robert-zaremba avatar Sep 04 '22 11:09 robert-zaremba

Hi @robert-zaremba . Thank you for this change. Would you be able to please split this PR up into smaller components to ease and speed up the review process?

We could probably start by splitting up types and osmoutils into another PR. What do you think?

p0mvn avatar Sep 05 '22 16:09 p0mvn

Here is the spec: https://github.com/osmosis-labs/osmosis/pull/2605

robert-zaremba avatar Sep 05 '22 19:09 robert-zaremba

@p0mvn OK - I will remove other files and leave types and osmoutils in this PR.

robert-zaremba avatar Sep 05 '22 22:09 robert-zaremba

I've removed keeper and module implementation in this PR

robert-zaremba avatar Sep 05 '22 22:09 robert-zaremba

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

github-actions[bot] avatar Sep 20 '22 00:09 github-actions[bot]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

github-actions[bot] avatar Oct 05 '22 00:10 github-actions[bot]

From the latest updates, streamswap is not planned to be pursued as a Go module so I'm going to close this for now. Thank you @robert-zaremba and please let me know if any concerns

p0mvn avatar Oct 24 '22 23:10 p0mvn

All good, thanks @p0mvn

robert-zaremba avatar Oct 25 '22 23:10 robert-zaremba