osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

Go module version v10 should be updated to true/tagged version v11

Open 08d2 opened this issue 3 years ago • 2 comments

The major version used in a git tag must be the same as the Go module version (defined in go.mod) at that revision. Otherwise, that rev isn't importable.

$ go get github.com/osmosis-labs/osmosis/v10@latest
go: added github.com/osmosis-labs/osmosis/v10 v10.1.1
$ go get github.com/osmosis-labs/osmosis/[email protected]
go: github.com/osmosis-labs/osmosis/[email protected]: invalid version: module path includes a major version suffix, so major version must match
$ go get github.com/osmosis-labs/osmosis/v11@latest
go: module github.com/osmosis-labs/osmosis@latest found (v1.0.4), but does not contain package github.com/osmosis-labs/osmosis/v11

So the change here would be

diff --git a/go.mod b/go.mod
index 000c6c61..fba340f1 100644
--- a/go.mod
+++ b/go.mod
@@ -1,4 +1,4 @@
-module github.com/osmosis-labs/osmosis/v10
+module github.com/osmosis-labs/osmosis/v11
 
 go 1.18
 

plus whatever import paths need to be updated.

08d2 avatar Aug 11 '22 13:08 08d2

Thanks for flagging! We decided to change the import paths once TWAP is in https://github.com/osmosis-labs/osmosis/pull/2304

@p0mvn do you think we at a point now where we can reopen this PR?

czarcas7ic avatar Aug 11 '22 14:08 czarcas7ic

Yes, I will work on this. Will address: https://github.com/osmosis-labs/osmosis/issues/2367 first to easily update both main and v11.x

p0mvn avatar Aug 11 '22 15:08 p0mvn

v11.0.1 went out that fixes this!

ValarDragon avatar Aug 16 '22 04:08 ValarDragon