osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

Published 20 hours ago • verified publisher icon osmosis-labs

[Epic] Quality assurance for events

Open p0mvn opened this issue 3 years ago • 3 comments

Background

During the internal audit, we discovered that the tests and documentation for events across all modules are limited. This is an epic to track work across modules

Stories

  • https://github.com/osmosis-labs/osmosis/issues/1942
  • https://github.com/osmosis-labs/osmosis/issues/2194
  • TBD: epochs
  • https://github.com/osmosis-labs/osmosis/issues/2270
  • TBD: mint
  • TBD: pool-incentives
  • TBD: tokenfactory
  • TBD: txfees

Acceptance Criteria

  • events are tested and documented across all modules
  • the design is consistent across modules

p0mvn avatar Jul 22 '22 18:07 p0mvn

We should investigate if events are emitted correctly in other modules and create issues for them, if applicable

p0mvn avatar Jul 22 '22 18:07 p0mvn

I can try looking into x/lockup as i'm pretty familiar with that module

stackman27 avatar Jul 23 '22 05:07 stackman27

I can try looking into x/lockup as i'm pretty familiar with that module

That would be awesome! Would you like to create an issue to track this? Similar to #1942 and #2194

p0mvn avatar Jul 29 '22 19:07 p0mvn

I can take care of x/mint or x/txfees

alexanderbez avatar Aug 18 '22 13:08 alexanderbez

Synched offline - will not pursue this further unless asked for guarantees by integrators. Will wait for more event improvements from the SDK and/or code gen what's possible

p0mvn avatar Aug 26 '22 02:08 p0mvn