osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

Published 20 hours ago • verified publisher icon osmosis-labs

Refactor distr_test.go to table-driven

Open hieuvubk opened this issue 3 years ago • 1 comments

I just refactor some tests in distr_test.go to table-driven for issue #1961:

  • TestAllocateAsset
  • TestReplaceDistrRecords
  • TestUpdateDistrRecords

hieuvubk avatar Jul 22 '22 15:07 hieuvubk

Good work on making these test cases table driven! Much cleaner! Just a couple of comments to further increase clarity 😄

czarcas7ic avatar Aug 07 '22 23:08 czarcas7ic

hey @hieuvubk could you please resolve the conflicts? We can merge this right after

p0mvn avatar Aug 16 '22 19:08 p0mvn

hey @hieuvubk could you please resolve the conflicts? We can merge this right after

yes sure

hieuvubk avatar Aug 17 '22 15:08 hieuvubk

Good to go, thanks @hieuvubk!

czarcas7ic avatar Aug 17 '22 16:08 czarcas7ic