osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

Published 20 hours ago • verified publisher icon osmosis-labs

Pool incentives grpc test

Open hieuvubk opened this issue 2 years ago • 2 comments

Refactor some tests in pool-incentives grpc_test.go to table drive

  • TestGaugeIds
  • TestDistrInfo
  • TestIncentivizedPools

hieuvubk avatar Jul 20 '22 14:07 hieuvubk

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

github-actions[bot] avatar Aug 07 '22 00:08 github-actions[bot]

I just refactored my tests, removed unnecessary loops. About expErr variables in DistrInfo, IncentivizedPools test, functions always return nil error. So I will check through record length and total weight Could u pls take a look @czarcas7ic @mattverse

hieuvubk avatar Aug 11 '22 05:08 hieuvubk

Thanks for the ping @hieuvubk sorry about how long it took me to get back to this. Would like one more approval and then we can merge!

czarcas7ic avatar Aug 22 '22 15:08 czarcas7ic