osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

Flag to remove wasm byte code from proposal list

Open czarcas7ic opened this issue 2 years ago • 4 comments

Background

As it stands on testnet, when listing proposals the list becomes unreadable due to all the byte code shown in each wasm prop.

Suggested Design

There are many ways to go about this, but I suggest we hide the wasm byte code by default, but can show the code with a flag

Acceptance Criteria

  • Proposal list is once again readable
  • Wasm byte code can be displayed if desired

czarcas7ic avatar Jun 29 '22 14:06 czarcas7ic

Screen Shot 2022-06-29 at 9 33 30 AM Goes on, and on, and on

czarcas7ic avatar Jun 29 '22 14:06 czarcas7ic

I would like to work on this issue! But could you please clarify which branch is used for development in osmosis-labs/wasmd repository?

pysel avatar Oct 03 '22 05:10 pysel

@czarcas7ic It seems like in order to fix this problem, SDK has to be changed. More specifically - x/gov/keeper/grpc_query.go file. It seems like this problem is too specific for changing sdk only for wasm, but if this issue is important to solve, we can force it.

pysel avatar Oct 06 '22 07:10 pysel

Since we utilize an sdk fork this should not be too difficult since we have control of what gets added. That being said, we are moving gov directly into osmosis soon as well

czarcas7ic avatar Oct 06 '22 14:10 czarcas7ic

I think getting static content not in the gov prop was fixed upstream?

ValarDragon avatar Apr 01 '24 09:04 ValarDragon