osmosis icon indicating copy to clipboard operation
osmosis copied to clipboard

Log Message - ERR no delegation distribution info

Open cfl0ws opened this issue 2 years ago • 7 comments

Background

During the network restart using v10.0.0 our logs displayed only the following message immediately after restarting osmosisd.

ERR no delegation distribution info

Upon reporting this to the Osmosis Validators discord channel, @ValarDragon explained the message was due to "no swaps in that pool" and asked me to create this issue so the log messaging could be improved.

Suggested Design

TBD

Acceptance Criteria

TBD

cfl0ws avatar Jun 12 '22 16:06 cfl0ws

I too have run into this problem after upgrading to Osmosisd 10.0.0. Once this issue shows up in the logs then the API stops responding (port 26657). A couple times I restarted cosmovisor and it started to work again. But then the "ERR no delegation distribution info" shows up and then the server stops working. Is there any more information on this?

SlingshotCade avatar Jun 20 '22 02:06 SlingshotCade

The API is down generally due to epoch time, which is a more a longstanding problem with queries aren't available during block execution.

ValarDragon avatar Jun 20 '22 03:06 ValarDragon

After investigation, noticed that we had this error not because the pool didn't have any swaps in between epochs, it's because we don't delete intermediary accounts. Working on a PR with the fix

mattverse avatar Jul 13 '22 08:07 mattverse

Hrmm, don't we need to be careful wrt when we need to delete intermediary accounts? (IIRC theres something in the spec about this)

ValarDragon avatar Jul 13 '22 13:07 ValarDragon

Can't find anything in spec as of now, the current plan im thinking of is deleting intermediary accounts that doesn't have any connections & delegations any more, I cant think of any instances where deleting can be dangerous atm.

If you feel concerned about it, we can also simply pass without returning error here?

mattverse avatar Jul 13 '22 14:07 mattverse

Regarding this issue, since I also face the same error, is it possible that it's causing a performance hit that I've described here in this ticket (https://github.com/osmosis-labs/osmosis/issues/2173) ?

effofxprime avatar Jul 20 '22 19:07 effofxprime

Epoch has performance hit mainly because of distribution logic and internal logics that's happening in epoch time, shouldn't have relation with the error log we see here

mattverse avatar Jul 21 '22 04:07 mattverse

I believe this has been fixed

ValarDragon avatar Jan 30 '23 14:01 ValarDragon