osmosis-frontend
osmosis-frontend copied to clipboard
Integrate Trust Wallet [500 USDC Reward!]
What is the purpose of the change
Documentation and Release Note
@isreallee82 is attempting to deploy a commit to the OsmoLabs Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| osmosis-frontend | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 20, 2024 2:51pm |
| osmosis-frontend-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 20, 2024 2:51pm |
| osmosis-testnet | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 20, 2024 2:51pm |
@isreallee82 is this building for you locally? It fails the build step on Vercel
sorry for late response didnt get a notification, its not failing locally @MaxMillington
I will rerun checks @MaxMillington
@isreallee82 Can you rebase and fix the conflicts and repush? Perhaps that will fix the broken build
alright I will do that @MaxMillington
@isreallee82 build is still failing
a min @MaxMillington
@MaxMillington, I suspect that the recent update to cosmokit-core may be causing some issues with the type definitions. I'll take some time to review the changes made in their documentation before the weekend to troubleshoot and resolve any potential conflicts.
@isreallee82 ping me when you've had a chance to look it over and I'll re-authorize the vercel deploy
sure I will @MaxMillington
Trust 2.7.0 browser extension is live with full cosmos dapp support
@isreallee82 just checking in on this
@MaxMillington still checking should have a positive feedback this weekend
Things should work right now @MaxMillington
It seems like you can't switch between two different mnemonics, trust wallet doesn't provide an event for that
Getting this error on BLD, IST token deposit/withdraw @isreallee82
@CryptoAssassin1 According to Trust Doc, Trust Wallet Browser Extension currently supports only Ethereum & EVM chains, and support for Cosmos is still in progress.
@CryptoAssassin1 According to Trust Doc, Trust Wallet Browser Extension currently supports only Ethereum & EVM chains, and support for Cosmos is still in progress.
Doc is just outdated it's not true
will look into that @CryptoAssassin1
Hi @isreallee82 any update on this?
sorry for the late response to this fix @MaxMillington I have not been able to test my changes as trust wallet get stuck loading on my browser, I will try again today and give feedback
Thanks @isreallee82 . Let us know what sorts of issues you run into and maybe we can help.
my chrome browser is stuck on this trust wallet loading
@isreallee82 what sorts of Network/Console errors do you get?
After a refresh got this
okay seems to work now
Walkthrough
The application's wallet integration capabilities have been significantly enhanced by adding new wallets to the registry, updating existing ones with additional features, and ensuring compatibility and functionality improvements. These changes focus on expanding support and enhancing the configuration of wallets within the system.
Changes
| File Path | Change Summary |
|---|---|
packages/web/config/wallet-registry.ts |
Added import for DownloadInfo from @cosmos-kit/core. Modified WalletRegistry array by adding new wallet configurations with specific properties like logo, lazyInstall, supportsChain, stakeUrl, governanceUrl, features, downloads, and mode for different wallets including "trust-extension", "trust-mobile", "keplr-extension", and others. Updated existing entries in WalletRegistry by adding the mode property with the value "extension" where applicable. |
packages/stores/src/account/base.ts |
Modified walletManagerAssets getter, adjusted parameter order in _createWalletManager, and converted accountNumber type in signDoc. |
packages/web/package.json |
Updated package versions including @cosmos-kit/core and related dependencies. |
packages/web/integrations/trust-walletconnect/registry.ts |
Introduced TrustMobileInfo export defining Trust Mobile wallet integration details. |
Poem
🐇✨ In the code garden, changes bloom, New wallets sprout under the moon. With updates sown, and versions new, Our app grows strong, robust, and true. 🌱🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
will look into that @CryptoAssassin1
@isreallee82 the issue is still there.