osmosis-frontend icon indicating copy to clipboard operation
osmosis-frontend copied to clipboard

Integrate Trust Wallet [500 USDC Reward!]

Open isreallee82 opened this issue 1 year ago • 137 comments

What is the purpose of the change

Documentation and Release Note

isreallee82 avatar Feb 03 '24 15:02 isreallee82

@isreallee82 is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 03 '24 15:02 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 2:51pm
osmosis-frontend-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 2:51pm
osmosis-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 2:51pm

vercel[bot] avatar Feb 04 '24 08:02 vercel[bot]

@isreallee82 is this building for you locally? It fails the build step on Vercel Screenshot 2024-02-08 at 9 26 44 AM

MaxMillington avatar Feb 08 '24 16:02 MaxMillington

sorry for late response didnt get a notification, its not failing locally @MaxMillington

isreallee82 avatar Feb 12 '24 21:02 isreallee82

I will rerun checks @MaxMillington

isreallee82 avatar Feb 12 '24 21:02 isreallee82

@isreallee82 Can you rebase and fix the conflicts and repush? Perhaps that will fix the broken build

MaxMillington avatar Feb 13 '24 15:02 MaxMillington

alright I will do that @MaxMillington

isreallee82 avatar Feb 13 '24 19:02 isreallee82

@isreallee82 build is still failing Screenshot 2024-02-13 at 2 50 37 PM

MaxMillington avatar Feb 13 '24 21:02 MaxMillington

a min @MaxMillington

isreallee82 avatar Feb 13 '24 22:02 isreallee82

@MaxMillington, I suspect that the recent update to cosmokit-core may be causing some issues with the type definitions. I'll take some time to review the changes made in their documentation before the weekend to troubleshoot and resolve any potential conflicts.

isreallee82 avatar Feb 14 '24 12:02 isreallee82

@isreallee82 ping me when you've had a chance to look it over and I'll re-authorize the vercel deploy

MaxMillington avatar Feb 14 '24 15:02 MaxMillington

sure I will @MaxMillington

isreallee82 avatar Feb 14 '24 15:02 isreallee82

Trust 2.7.0 browser extension is live with full cosmos dapp support

Milerius avatar Feb 19 '24 12:02 Milerius

@isreallee82 just checking in on this

MaxMillington avatar Feb 22 '24 17:02 MaxMillington

@MaxMillington still checking should have a positive feedback this weekend

isreallee82 avatar Feb 22 '24 21:02 isreallee82

Things should work right now @MaxMillington

isreallee82 avatar Mar 04 '24 10:03 isreallee82

It seems like you can't switch between two different mnemonics, trust wallet doesn't provide an event for that

DavideSegullo avatar Mar 04 '24 18:03 DavideSegullo

Getting this error on BLD, IST token deposit/withdraw @isreallee82 image

CryptoAssassin1 avatar Mar 04 '24 19:03 CryptoAssassin1

@CryptoAssassin1 According to Trust Doc, Trust Wallet Browser Extension currently supports only Ethereum & EVM chains, and support for Cosmos is still in progress.

isreallee82 avatar Mar 05 '24 01:03 isreallee82

@CryptoAssassin1 According to Trust Doc, Trust Wallet Browser Extension currently supports only Ethereum & EVM chains, and support for Cosmos is still in progress.

Doc is just outdated it's not true

Milerius avatar Mar 05 '24 07:03 Milerius

will look into that @CryptoAssassin1

isreallee82 avatar Mar 05 '24 11:03 isreallee82

Hi @isreallee82 any update on this?

MaxMillington avatar Mar 13 '24 09:03 MaxMillington

sorry for the late response to this fix @MaxMillington I have not been able to test my changes as trust wallet get stuck loading on my browser, I will try again today and give feedback

isreallee82 avatar Mar 13 '24 12:03 isreallee82

Thanks @isreallee82 . Let us know what sorts of issues you run into and maybe we can help.

MaxMillington avatar Mar 13 '24 13:03 MaxMillington

Screenshot 2024-03-13 at 2 25 13 PM

my chrome browser is stuck on this trust wallet loading

isreallee82 avatar Mar 13 '24 13:03 isreallee82

@isreallee82 what sorts of Network/Console errors do you get?

MaxMillington avatar Mar 13 '24 14:03 MaxMillington

Screenshot 2024-03-13 at 6 24 41 PM

After a refresh got this

Screenshot 2024-03-13 at 6 28 09 PM

isreallee82 avatar Mar 13 '24 17:03 isreallee82

okay seems to work now

isreallee82 avatar Mar 13 '24 21:03 isreallee82

Walkthrough

The application's wallet integration capabilities have been significantly enhanced by adding new wallets to the registry, updating existing ones with additional features, and ensuring compatibility and functionality improvements. These changes focus on expanding support and enhancing the configuration of wallets within the system.

Changes

File Path Change Summary
packages/web/config/wallet-registry.ts Added import for DownloadInfo from @cosmos-kit/core. Modified WalletRegistry array by adding new wallet configurations with specific properties like logo, lazyInstall, supportsChain, stakeUrl, governanceUrl, features, downloads, and mode for different wallets including "trust-extension", "trust-mobile", "keplr-extension", and others. Updated existing entries in WalletRegistry by adding the mode property with the value "extension" where applicable.
packages/stores/src/account/base.ts Modified walletManagerAssets getter, adjusted parameter order in _createWalletManager, and converted accountNumber type in signDoc.
packages/web/package.json Updated package versions including @cosmos-kit/core and related dependencies.
packages/web/integrations/trust-walletconnect/registry.ts Introduced TrustMobileInfo export defining Trust Mobile wallet integration details.

Poem

🐇✨ In the code garden, changes bloom, New wallets sprout under the moon. With updates sown, and versions new, Our app grows strong, robust, and true. 🌱🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 14 '24 03:03 coderabbitai[bot]

will look into that @CryptoAssassin1

@isreallee82 the issue is still there.

CryptoAssassin1 avatar Mar 14 '24 13:03 CryptoAssassin1