Find false roundabouts

[geohacker]

cc @maning @batpad @Rub21

[geohacker]

Lots of false positives. I bet the tile edge is messing with the output. Gotta do the buffer magic.

[Rub21]

@geohacker I think this is quite same as https://github.com/osmlab/osmlint/pull/197

[geohacker]

@Rub21 I'm not sure what https://github.com/osmlab/osmlint/pull/197 does. Could you explain? I'm not able to comprehend the code. cc @dannykath

@Rub21 - could you please keep me, @maning and @batpad in the loop before you are merging PRs? Thank you. Let's make sure there's enough context, inline documentation, and review.

[Rub21]

@geohacker As the name said, this is a validator to detect the missing roundabout. The Peru team is working building these validators as part of hack days, About the code, is not complicated, we are evaluating if an oval has entry and exit routes, and if is not exist a roundabout and oneways, it should be missing a junction: roundabout Even can we convert this issue Find false roundabouts doing some changes on the algorithmic https://github.com/osmlab/osmlint/pull/197, you can evaluate the output here: https://gist.github.com/anonymous/a07e80e222eee9d39cc9a8ff7473800f

I've been notification you in the past in other tickets, but I spend days without a response, basically on checking the code, I think a got a good experience writing these algorithms and the code is fine. but if you have more suggestion to improve it would be great to know and improve them.

[Rub21]

I forgot to add here, we are using this to build the validator https://github.com/osmlab/osmlint/pull/197 http://wiki.openstreetmap.org/wiki/Tag:junction%3Droundabout#How_to_map