osmlint icon indicating copy to clipboard operation
osmlint copied to clipboard

overlappinghighway linter improvements

Open srividyacb opened this issue 6 years ago • 3 comments

From https://github.com/osmlab/osmlint/issues/271

Reworked on overlapHighway linter to output the overlapping LineString instead of Point/MultiPoint. Here is the sample output.

Now the output is having the linter type and the overlapping highway type in the metadata.

image

@maning Can you give it a spin on a QA-Tiles extract and verify if its working as expected ?

cc @Ramshackle-Jamathon

srividyacb avatar Jun 27 '18 11:06 srividyacb

Updated the bug of adding _fromWay, toWay and overlapping _type to the output featureCollection. New [sample-output] (https://gist.github.com/srividyacb/9dba1fc883aa8704b70409517a066891) after the bug fixes.

image

@Ramshackle-Jamathon - There are few duplicates for highway if they are any overlapping and selfIntersecting highway together. Need to find a way to remove them.

cc @maning

srividyacb avatar Jun 28 '18 12:06 srividyacb

@srividyacb could we add a flag to have overlapping ignore selfIntersecting Highways?

Ramshackle-Jamathon avatar Jun 29 '18 15:06 Ramshackle-Jamathon

Per voice with @maning - duplicates are less compared to the real errors thrown and we can ignore them.

But there are issues with how linter _type, fromWay and toWay are assigned to the output. Tried debugging but not able to find why they are incorrect sometimes. @Ramshackle-Jamathon can you see if you can find any bug here ?

srividyacb avatar Jul 03 '18 09:07 srividyacb