Test - manually fix special_co = A addresses

[Rub21]

First test export of edit URLs for addressing special_co=A - see https://github.com/osmlab/nycbuildings/issues/117

https://gist.github.com/lxbarth/30267f8ec091063e844e

I created this export with this script: https://github.com/osmlab/nycbuildings/tree/master/fixes/clean-up-special_co-address

Each link opens a building in JOSM like so:

I'm proposing manual edits rather than an automatic method, because:

• In some address the users add new tag aside from import.
• Do a small change sets, in small places.
• Consult in some unclear address.
• Working with two or three person in team, it could be take around two day in finish this job, let me know to start to work

Next action:

• @lxbarth + @Rub21 review
• (per voice) @Rub21 write up task instructions ( @planemad - can you help here?)

[lxbarth]

Ok, I like the idea of doing this manually.

Before we start with this task:

1. We need crystal clear task instructions. Right now nothing is documented and we leave it completely up to the beholder what to do with this data. The crucial reference layer [1] is not mentioned on this ticket and there are no instructions on how to interpret it.
2. Let's force people to download fresh data. It makes me queasy that we offer data right from the task-link. I'm I overly worried about this? What if data on server and the data on the task-link are out of sync?

[1] https://{switch:a,b,c}.tiles.mapbox.com/v4/ruben.7a3a284e/{z}/{x}/{y}.png?access_token=pk.eyJ1IjoicnViZW4iLCJhIjoiYlBrdkpRWSJ9.JgDDxJkvDn3us36aGzR6vg

[Rub21]

@lxbarth :

We need crystal clear task instructions. Right now nothing is documented and we leave it completely up to the beholder what to do with this data. The crucial reference layer [1] is not mentioned on this ticket and there are no instructions on how to interpret it.

Arun did the documentation, https://github.com/osmlab/nycbuildings/wiki/Import-cleanup, it is okay

. It makes me queasy that we offer data right from the task-link.

We could work in a task manager, but it could be take more time. other alternative is work in to-fix.

let me know what is in your mind to fix.

What if data on server and the data on the task-link are out of sync?

The solution to avoid the out of sync is work just few person, each person can work in one page, also over-pass take around 30 minute on refresh the data , I think, if we work that way we will avoid the out of sync

• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/a-urls-1.md
• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/a-urls-2.md
• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/a-urls-3.md
• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/a-urls-4.md
• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/b-urls-1.md
• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/b-urls-2.md
• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/b-urls-3.md
• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/b-urls-4.md
• https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/b-urls-5.md

@lxbarth @planemad what do you think about?

[lxbarth]

@Rub21 @planemad - this looks great, my edits are in: https://github.com/osmlab/nycbuildings/wiki/Clean-up-special-A-B-addresses (renamed title, which moved the page)

. It makes me queasy that we offer data right from the task-link.

@Rub21 using Github tickets is ok (no need for tasking manager or to-fix), what makes me queasy is that the links in the Github ticket load data from overpass API.

• This runs the risk of out of sync data
• And it invites editing OSM without having the full context of all data
• For no apparent advantage - why not just load the area around the address directly from the OSM API? Much safer.

[Rub21]

@lxbarth @planemad

For no apparent advantage - why not just load the area around the address directly from the OSM API? Much safer.

My first mind was, just find the special_co(A,B) address and remove all those address, but now after check out more,We have to review each situation of address and for that we need the complete area.

I am going to fix this on script to get all area in JOSM.

[Rub21]

@lxbarth @planemad , I fixed the script and now is possible to download per block from OSM API. Example additionally, I've done new maps, from each files, and added Ordinal number to address and simplified the number house e.x 34-006 -> 34-6

• a: https://api.tiles.mapbox.com/v4/ruben.ma4ko888/page.html?access_token=pk.eyJ1IjoicnViZW4iLCJhIjoiYlBrdkpRWSJ9.JgDDxJkvDn3us36aGzR6vg#12/40.7549/-73.8338
• b: https://api.tiles.mapbox.com/v4/ruben.ma4lak4o/page.html?access_token=pk.eyJ1IjoicnViZW4iLCJhIjoiYlBrdkpRWSJ9.JgDDxJkvDn3us36aGzR6vg#12/40.7078/-73.8846

@planemad The url for JOSM on document was updated.

[lxbarth]

@Rub21 - instead of:

http://127.0.0.1:8111/import?url=http://api.openstreetmap.org/api/0.6/map?bbox=-L,B,R,T

do:

http://127.0.0.1:8111/load_and_zoom?left=L&bottom=B&right=R&top=T

To zoom to the address and not to the entire loaded data.

[Rub21]

@lxbarth both are the same, I changed the url. https://github.com/osmlab/nycbuildings/blob/master/fixes/clean-up-special_co-address/index.js#L13

[colinreilly]

I am going to have my staff clean up the export of address points so they are, for lack of a better term, more 'user friendly'. We'll remove the added zeros to the hyphenated addresses. Let me know what else would make the data better. Now is the time to speak up.

[lxbarth]

@colinreilly - that's great.

We'll remove the added zeros to the hyphenated addresses.

This is great. Note that we stripped leading zeros from all house numbers but for Queens style hyphened house numbers we padded the post-hyphen portion with zeros up to two digits https://github.com/osmlab/nycbuildings/blob/master/convert.py#L47 and https://github.com/osmlab/nycbuildings/issues/92

Let me know what else would make the data better. Now is the time to speak up.

I remember culling many addresses because they were straight up planning addresses or addresses where we didn't have a high confidence level of whether they were in use. Anything you can do to clarify the status of various types of addresses is great.

[colinreilly]

@lxbarth Removing zero padding. Example 42-001 would become 42-01 as it is in reality.

Just sent you a file via dropbox of the deltas. Processing steps from the analyst:

Buildings Used the LAST_MODIFY_DATE. Deletes came form the building_historic table (available on the open data portal) using the date form LAST_MODIFY_DATE. As for the additions and modifications, since only the LAST_MODIFY_DATE is being updated I could not tell which was an add and modify. Lumped together in single shapefile.

Addresses Based on the dates being recorded in the table. For the deletes I had to go back to an archive table the way it was on 9/1/2013 and I did a join on the ADDRESSPOINTID and if there was no match we assume it was deleted.

[lxbarth]

@colinreilly - this is great. @Rub21 - dropbox file is here https://www.dropbox.com/s/r1v7voeew7qr515/NYC_changes_OSM.zip?dl=0 - let's talk as soon as you have had a chance to take a look at it.

[Rub21]

@lxbarth I saw the files, let me know when you want to talk.