name-suggestion-index icon indicating copy to clipboard operation
name-suggestion-index copied to clipboard

Malteser Hilfsdienst is brand or operator?

Open LaoshuBaby opened this issue 1 year ago • 0 comments

Now when run npm run build it will give a warning:

⚠️   Warning - matchIndex errors:
----------------------------------------------------------------------
  `key/value/name` occurs multiple times in the match index.
  To resolve these, make sure the key/value/name does not appear in multiple trees
    (e.g. `amenity/post_office/ups` should not be both a "brand" and an "operator"
----------------------------------------------------------------------
Duplicate cache key "amenity/recycling/q1318397" in trees "operators" and "brands", check items: malteserhilfsdienst-6737d9
total 1

This is because malteserhilfsdienst-6737d9 in operators/amenity/recycling.json and malteserhilfdienst-f6fab4 in brands/amenity/recycling.json are same entity, they have the same wikidata.

Details are shown below:

https://github.com/osmlab/name-suggestion-index/blob/ec766cfdec7d88dfdf2ea3455fb97eae15ff64c4/data/operators/amenity/recycling.json#L2190-L2199

https://github.com/osmlab/name-suggestion-index/blob/844909e140354d8e7857a71be99401115bd0eb29/data/brands/amenity/recycling.json#L186-L198

Maybe we need a German mapper review this and select which one should be use, and select proper matchNames and tags.

LaoshuBaby avatar Aug 11 '22 16:08 LaoshuBaby