editor-layer-index icon indicating copy to clipboard operation
editor-layer-index copied to clipboard

modifying and verifying privacy policy urls for sources/world

Open jeffreyameyer opened this issue 4 years ago • 5 comments

Not sure why the head repo here is the OHM ELI, but submitting against gh-pages in the hopes all is actually usable...

jeffreyameyer avatar Oct 20 '21 20:10 jeffreyameyer

Also... included a few entries of '"privacy_policy_url": "false"' in anticipation of support for this in an updated strict checker...

jeffreyameyer avatar Oct 20 '21 20:10 jeffreyameyer

sources/world/OpenPTMap-overlay.geojson → sources/world/OpenPTMap-overlay.geojson.del

Did you mean to rename that file or delete it?

sources/world/.OpenTopoMap.geojson.swp

shouldn't be commited

andrewharvey avatar Nov 13 '21 00:11 andrewharvey

Apart from my comments, everything else looks good! Thanks.

Also... included a few entries of '"privacy_policy_url": "false"' in anticipation of support for this in an updated strict checker...

We need to document if this should be "false" or false or null. I think false is best so it can be String or Boolean. Though I'm happy to circle back to these later once the schema and documentation has been updated.

andrewharvey avatar Nov 13 '21 00:11 andrewharvey

@jeffreyameyer Thanks for searching for the privacy policies! The situation that there is no way to document that there is none is not satisfying. I'm a bit hesitant to introduce something that might break something for a data consumer without any notification. Would it be an option to just leave the '"privacy_policy_url": "false"' out for now?

rbuffat avatar Nov 14 '21 15:11 rbuffat

Agreed @rbuffat we can leave it out for now, and follow up with a separate schema change giving data consumers notice/checking with them about using false to indicate there is no privacy policy.

andrewharvey avatar Nov 14 '21 22:11 andrewharvey