changeset-map icon indicating copy to clipboard operation
changeset-map copied to clipboard

Highlight modified nodes on ways

Open planemad opened this issue 9 years ago • 2 comments

Look at this edit: http://osmlab.github.io/changeset-map/#38703453 (OSM) by calfarome on changeset-map

screenshot 2016-08-01 16 46 23

The visualization shows that 1 way was modified, which is technically correct, but does not tell what was the change.

Inspecting the history for the way geometry in JOSM, we see:

screenshot 2016-08-01 16 11 21

So the way was modified by adding a single new node into it by calfarome.

Checking the history of the node, we see that this node was not created nor edited by calfarome!

So what actually happened? This was likely the edit:

untitled2 The node at the end of the disconnected way was joined to the nearby way. Hence no change to the node, but just the way

Improving the visualization

  • Clearly show the change in the way by highlighting new/deleted/moved nodes

This would help reviewers quickly understand what the change was, instead of using various tools to piece together the puzzle.

cc @ajithranka @maning @rasagy

planemad avatar Aug 01 '16 11:08 planemad

@planemad Any ideas on how to do this, or can we reopen this ticket later when we find more examples like this? As of now, the extra node doesn’t seem to be coming in the changeset, so there’s no way for us to visualize this. cc @ajithranka

rasagy avatar Apr 05 '17 11:04 rasagy

the extra node doesn’t seem to be coming in the changeset

The osmchange xml has a reference to the node <nd ref="2317541619"/>. Highlighting the actual node that changed will be a huge improvement since it focuses the reviewers attention exactly where it is needed.

planemad avatar Apr 06 '17 08:04 planemad