changeset-map icon indicating copy to clipboard operation
changeset-map copied to clipboard

Permalink to a feature broken

Open nrenner opened this issue 7 years ago • 1 comments

I'm submitting a ...

  • [x] bug report
  • [ ] ~~feature request~~
  • [ ] support / question

Brief Description

Permalink to a feature (#5) is no longer working in the standalone deployment at http://osmlab.github.io/changeset-map/.

What is the current behaviour, (attach relevant screenshots) ?

  • Passing a feature type and id in the URL does not open the tag diff for the feature: http://osmlab.github.io/changeset-map/#53423684/way/130625913
  • Selecting a feature on the map does not update the URL hash
  • Calling http://osmlab.github.io/changeset-map/ without hash parameters results in a console error:
    TypeError: cMap is undefined - index.js:45

What is the expected behaviour ?

  • http://osmlab.github.io/changeset-map/#53423684/way/130625913
    selects feature and opens tag diff for feature
  • http://osmlab.github.io/changeset-map/#53423684
    and selecting a feature on the map adds feature to the URL, e.g. adds /way/130625913
  • http://osmlab.github.io/changeset-map/ produces no errors in console + entering 53423684 + selecting a feature on the map adds feature to the URL

When does this occur ?

Always. Worked about six weeks ago, probably broken since the recent gh-pages update.

How do we replicate the issue ?

see above

Please tell us about your environment:

Current Firefox 57.0.4 (64-Bit) and Chrome on Ubuntu 16.04.

Other Information / context:

nrenner avatar Jan 22 '18 19:01 nrenner

Thanks for the report, @nrenner! I'll take a look on this soon

willemarcel avatar Jan 22 '18 20:01 willemarcel