atlas-checks icon indicating copy to clipboard operation
atlas-checks copied to clipboard
verified publisher icon osmlab

[Fix Suggestions] Connectivity Check

Open ylinzhi opened this issue 5 years ago • 3 comments

Which Atlas check is the fix suggestion related to?

Connectivity Check Description: This check identifies nodes that should be connected to nearby nodes or edges Script: https://github.com/osmlab/atlas-checks/blob/e36a240f37344c99a25b00eb42c8e1b77b228a88/src/main/java/org/openstreetmap/atlas/checks/validation/points/ConnectivityCheck.java

Describe more details of suggested fix(es)

Suggested Fix 1:

  • Type of fixing: Geometry fix

  • Operation: Modify

  • Suggested Action: connect the node to proper nearest node or edge

Is there any code enhancement needed if adding the fix suggestion component?

No

ylinzhi avatar Oct 19 '20 05:10 ylinzhi

This will involve some complicated tag merging for the 2 nodes, but worth a shot.

Bentleysb avatar Nov 02 '20 23:11 Bentleysb

@sayas01 can you assign this to @vladlemberg please

atiannicelli avatar Oct 26 '21 20:10 atiannicelli

@ylinzhi, @sayas01, @Bentleysb, @atiannicelli

Hello everyone, I went through cases from the latest daylight MR challenge. My opinion its a bit risky to offer a AutoFix suggestion for that challenge. Some of the cases visually looks straightforward to connect but after manual investigation it turns out as incorrect mapping. Some examples (bad data): https://maproulette.org/challenge/17794/task/100038393 image

image

Complicated Cases: Node should be disconnected from the Admin Boundary, then connect to navigable road. https://maproulette.org/challenge/17794/task/100026727

Tertiary Road connected via unmaintained track road. image https://maproulette.org/challenge/17794/task/100016546

Any opinion, suggestion ? Should we AutoFix only super clean cases ? So far I don't have method to isolate those.

vladlemberg avatar Nov 10 '21 19:11 vladlemberg