osm-welcome-tool icon indicating copy to clipboard operation
osm-welcome-tool copied to clipboard

Published 20 hours ago • verified publisher icon osmbe

Add manual refresh button

Open thibaultmol opened this issue 5 years ago • 3 comments

Just had the situation where I spotted a new user while going trough osmCha (was done 2 hours ago), but seems like neis already updated because that user also showed up in my rss feed. So being able to manually refresh from neis would be nice (so I could mark that person as having being welcomed)

thibaultmol avatar Jan 22 '20 14:01 thibaultmol

Hello @thibaultmol Even though I understand the request, I would not push forward its implementation ! The request towards Pascal Neis API takes quite some time and you would risk to corrupt the files if 2 "update requests" are triggered at the same time (or at least if the 2nd is triggered before the end of the 1st).

jbelien avatar Jan 22 '20 16:01 jbelien

I see, but you couldn't you implement it so that it checks if there is a request in progress, and if so, don't request a new one and just wait on the current one? EDIT: sorry if I'm glansing over something which would not make that doable

thibaultmol avatar Jan 22 '20 17:01 thibaultmol

To be honest, the codebase is quite old (and not mine) and I don't really have the time (or the will) to do more than (small) fixes.

It would indeed be a nice feature to add, if anyone is interested to submit a PR, I'll be more than happy to merge it !

jbelien avatar Jan 22 '20 17:01 jbelien