osmaczko
osmaczko
> However, there is a problem if we create an account with a public key that is already in a group chat or if we synchronize a new device: the...
I stumbled upon the same issue today. `NodeConfig` handling is far from ideal. I came up with an ad-hoc solution for my problem, which I believe will work for this...
FYI: @igor-sirotin
> Yes, but as far as I remember I couldn't use these functions when they were in _test.go file. Correct, you cannot use test utilities defined in one package within...
@igor-sirotin @richard-ramos, re-requesting review. Many other areas have also been updated. I’ve essentially removed the use of the geth logger across the codebase, though there's still some work left to...
Desktop PR created: https://github.com/status-im/status-desktop/pull/16589, will run full regression tests.
Mobile PR created: https://github.com/status-im/status-mobile/pull/21492
> I'm a bit worried of massive usage of `zap.Error`, because it automatically adds `errorVerbose` with the whole call stack, and it's usually 10x longer than the log line itself....
@jakubgs I would love to hear your opinion. Is there anything else I should think about?
Thanks for the quick response. That makes a lot of sense and will keep the CI scripts untouched. I would apply both solutions: remove generated files from the repo and...