osm2pgsql icon indicating copy to clipboard operation
osm2pgsql copied to clipboard

Deprecating gazetteer output

Open lonvia opened this issue 5 years ago • 1 comments

With the flex output, there is no need to have a separate gazetteer output, as it allows to configure most of what we need. This tickets collects the features that would still be needed on the osm2pgsql side to get the flex output on par with the current gazetteer implementation:

  • [x] Geometry caching. Gazetteer occasionally calls add_row() twice for the same object.
  • [ ] Do not create an index on the geometry column.
  • [x] Do not cluster table.
  • [ ] Disable handling of forward dependencies on a per-table base.

The tasks for the Nominatim side are collected at https://github.com/osm-search/Nominatim/issues/2047.

lonvia avatar Nov 06 '20 15:11 lonvia

Having Nominatim use the flex output, would open up the possibility of generating a single database for rendering and geocoding. Something that a lot of people want.

At a minimum this would need some mechanism for handling the difference in processing though: For the rendering db osm2pgsql needs to handle the forward dependencies in append mode, Nominatim doesn't need that.

joto avatar Nov 25 '20 13:11 joto

With the merge of #1847 another big step towards this has been taken. See also https://nominatim.org/2022/11/28/towards-flex.html .

joto avatar Dec 07 '22 19:12 joto

Handling of forward dependencies has been rendered moot by https://github.com/osm-search/Nominatim/pull/2927. https://github.com/osm-search/Nominatim/pull/2932 fully switches Nominatim to flex.

The one task that remains is to remove the gazetteer output. I don't think we need much of a deprecation period as the output was only ever meant to be used with Nominatim.

lonvia avatar Dec 23 '22 18:12 lonvia

Closing in favour of #1870.

joto avatar Jan 05 '23 08:01 joto