osmose-backend icon indicating copy to clipboard operation
osmose-backend copied to clipboard

Soundex reported for statue despite being for streets

Open matkoniecz opened this issue 1 year ago • 3 comments

https://osmose.openstreetmap.fr/en/issue/f3e4887c-6a2d-1fa1-f7cd-597f64e1b435

source 	8423
item 	5050
class 	1
lat lon 	50.0614682 19.9379946 

screen01

A street name "sounds" similar to that of another street but is not spelled the same way.

triggered by https://github.com/Helium314/SCEE/issues/504#issuecomment-1872950553

matkoniecz avatar Dec 31 '23 18:12 matkoniecz

also, I have no idea what and why is supposed to be wrong here

matkoniecz avatar Dec 31 '23 18:12 matkoniecz

I must say I don't 100% understand how the code of the soundex test works, but to my knowledge it looks for names that "sound" similar. Thereby for instance detecting typo's like James Bond vs James Bont. However, this also means that it'll inherently have some false positives (like in Dutch Kennedylaan vs Kennedybaan: Kennedy lane vs Kennedy track). Human verification is very important with this one.

I don't know if it was supposed to be restricted to streets (in which case a highway-check is missing) or not (in which case the text should be updated)

Famlam avatar Dec 31 '23 22:12 Famlam

There is name in street but common with other objects and it is better to have more data for self comparing.

See also #813.

also, I have no idea what and why is supposed to be wrong here

Yes the title is bad, it should say what is wrong, not how it works.

frodrigo avatar Jan 01 '24 09:01 frodrigo

also, I have no idea what and why is supposed to be wrong here

yes, it would be nice if the test mentioned from which element it got that other/similar name. Currently it is guessing work (and it may well be that it is the other element that needs editing, not the highlighted one).

Yes the title is bad, it should say what is wrong, not how it works.

Perhaps title="Possibly misspelled name" would fit better then "Soundex test" ?

There is name in street but common with other objects and it is better to have more data for self comparing.

So if that is intentional, perhaps detail='A street name "sounds" similar to that of another street/place but is not spelled the same way.' would be less confusing then? (bold text added).

mnalis avatar Jul 29 '24 05:07 mnalis

The improved texts are now live

Famlam avatar Aug 12 '24 21:08 Famlam