osmose-backend icon indicating copy to clipboard operation
osmose-backend copied to clipboard

False positive for parking:condition:[side] without parking:lane:[side] value

Open rskedgell opened this issue 2 years ago • 5 comments

The tests in Highway_Parking_Lane.py reflect the situation before Proposed features/Parking lane conditionals (https://wiki.openstreetmap.org/w/index.php?oldid=2289049) was approved on 2022-01-21.

This moved the values no_parking and no_stopping for parking:lane=* to parking:condition=, so a false positive if raised for e.g. parking:condition:=no_parking|no_stopping, but not for the now deprecated parking:lane:*=no_parking|no_stopping.

rskedgell avatar Aug 02 '22 06:08 rskedgell

Ok, should be fixed here https://github.com/osm-fr/osmose-backend/blob/master/plugins/Highway_Parking_Lane.py

frodrigo avatar Aug 03 '22 12:08 frodrigo

Done.

frodrigo avatar Aug 13 '22 09:08 frodrigo

Osmose continues to report a warning when parking:condition:[side] is used without parking:lane:[side]

According to the wiki at Key:parking:condition: "Both can be used independently of each other, they do not necessarily require the other "

So, what about this warning?

blef00fr avatar Aug 15 '22 14:08 blef00fr

Issue should be re-opened, I still get this warning.

Discostu36 avatar Sep 11 '22 14:09 Discostu36

Unlike the parking:condition (which often requires ground surveys), parking:lane can mostly be deduced from areal imagery. So I personally, when I fixed the bug in the initial post, kept this check in despite being an "allowed" situation. It's a good suggestion for things that could be improved easily. (Just like for instance signals should have a railway:signal:direction=* tag, Unfinished power minor line, Unmapped surveillance camera, Operator can be completed with operator:wikidata and several other errors).

Famlam avatar Sep 18 '22 11:09 Famlam

Can we close this one now?

frodrigo avatar Nov 06 '22 14:11 frodrigo

As far as my comment is concerned, I think so.

blef00fr avatar Nov 06 '22 14:11 blef00fr